Add support for Skottie #3143
Merged
Add support for Skottie #3143
+112,679
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Skottie, a new animation format, by introducing new drawing commands, extending the recorder and player interfaces, and defining the associated types and factory for Skottie animations. Key changes include:
- Adding a new drawing command (drawSkottie) in the Skia recorder commands.
- Extending the Visitor, Recorder, ReanimatedRecorder, Player, and Core modules to handle the new Skottie node type.
- Introducing new factory and type definitions (JsiSkottieFactory, JsiSkottieAnimation, and corresponding Skottie types) along with updates to React components and test assets.
Reviewed Changes
Copilot reviewed 47 out of 66 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/skia/src/sksg/Recorder/commands/Drawing.ts | Replaces an existing fill command with a drawSkottie command that seeks and renders Skottie animations. |
| packages/skia/src/sksg/Recorder/* and Core.ts | Extends the recorder and player logic to support the new Skottie command and NodeType. |
| packages/skia/src/skia/* | Adds new Skottie factory, animation implementation, and updates related type exports. |
| packages/skia/src/renderer/* | Introduces a new Skottie component and test assets for rendering Skottie animations. |
| packages/skia/src/skia/types/* | Adds new type definitions for Skottie animations and updates related enums. |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.